fix: correct Minute/Second toString for negative values - #105
Merged
sshanks-kx merged 1 commit intoJul 30, 2026
Merged
Conversation
kdb+ minute and second values can be negative (e.g. the result of time arithmetic such as `neg 01:30`). Their toString rendered a minus sign on every component because Java integer division and remainder are both negative for a negative operand: Minute(-90) -> "-01:-30" (expected "-01:30") Second(-3661) -> "-01:-01:-01" (expected "-01:01:01") Apply the sign once and format the magnitude, mirroring how Timespan.toString already handles negatives. Extend the unit tests with negative and beyond-24h cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minute.toString()andSecond.toString()render a stray minus sign on every component for negative values.kdb+
minuteandsecondvalues can be negative (e.g. the result of time arithmetic such asneg 01:30). The value was formatted asi2(i/60) : i2(i%60), and because Java integer division and remainder are both negative for a negative operand, each component received its own minus sign:Minute(-90)-01:-30-01:30Minute(-30)00:-30-00:30Second(-3661)-01:-01:-01-01:01:01Change
Apply the sign once and format the magnitude, mirroring how
Timespan.toString()already handles negatives. Positive values — including values beyond 24h, e.g.Minute(1500)→25:00— are unchanged.Testing
Extended
testMinuteToString/testSecondToStringwith negative and beyond-24h cases. Full suite green (84 tests, no regressions).